Slugs #155
Merged
Slugs #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virogenesis
requested changes
Mar 20, 2019
pyconbalkan/coc/models.py
Outdated
| def save(self, *args, **kwargs): | ||
| if not self.slug: | ||
| self.slug = slugify(self.title) | ||
| elif self.slug != slugify(self.title): |
There was a problem hiding this comment.
This will force the slug to be a slugified version of self.title, we want to be able to define it, but only assign as a default value the slugified version.
Could something like default=lambda self, x: slugify(self.title) work ?
Probably not as the field doesn't have the scope of self.
But you get my drift.
There was a problem hiding this comment.
I think I got it:
- If post had no slug and no slug is entered - make slug from the title
- if post had slug but new one is entered - save slug, overwriting previous value
- if post had slug and no new one is entered - do nothing
Actually, it's only needed to remove elif condition, right?
I changed it and if it's ok you can merge it.
virogenesis
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this can be safely merged. Models don't need to be updated, no migration required, just save news post and slug will be generated from the post title. I implemented the same model for COC but I am not sure if it's needed. All other entities that have slug already had some logic for auto generating slugs.