Andrei Trukhan #37
Open
Andrei Trukhan #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test_main.py полностью отрабатывает на локальной машине. Не понимаю, почему не запускается тут. |
| @@ -0,0 +1,105 @@ | |||
| from pycalc.main import Stack | |||
| from pycalc.consts import * | |||
There was a problem hiding this comment.
Импорт через звездочку -- это зло
| from pycalc.consts import * | ||
|
|
||
|
|
||
| def check_mistakes(expression, functions={}, mode=0): |
There was a problem hiding this comment.
Крайне не рекомендуется использование изменяемых типов данных в качестве аргумента по умолчанию в функциях. Такие объекты создаются лишь единожды при создании объека функции, а не каждый раз при ее выполнении.
|
|
||
| if len(expression) == 0: | ||
| if mode == 0: | ||
| return "ERROR: empty expression" |
There was a problem hiding this comment.
Для этих целей нужно использовать исключения, а не возвращаемые значения
| return result | ||
|
|
||
|
|
||
| def separate(expression): # separates expression to logical parts |
There was a problem hiding this comment.
Для этих целей лучше спользовать класс или отдельный модуль, чем функция
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release version.