-
Notifications
You must be signed in to change notification settings - Fork 544
Bugfixes in ParmEst and DoE #3512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
related to issue Pyomo#3372
First bug does not revert the parameter perturbation during sequential FIM computation. Second bug was not properly populating the results object.
Updated tests to match the corrected error messages.
FYI, @djlaky , we are seeing lots of intermittent failures on Windows/conda setup. Not related to your changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3512 +/- ##
=======================================
Coverage 88.64% 88.65%
=======================================
Files 881 881
Lines 100918 100919 +1
=======================================
+ Hits 89461 89467 +6
+ Misses 11457 11452 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added comment to be explicit that dict.fromkeys() is used instead of set() to preserve parameter ordering and thus make the problem deterministic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but in the future, DoE needs to be gone through and wrapped to 88 columns (for style consistency / black)
Sure thing. I will add this to the list of To-Dos (#3345) |
Fixes #3372 .
Fixed error in #3372 with suggestion. Ordering appears to be deterministic with new convention.
Also fixed two bugs within pyomo.doe.
Summary/Motivation:
Improving code quality and consistency through bugfixes.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: