-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend valid types for PyROS solver argument uncertain_params
#3439
Open
shermanjasonaf
wants to merge
23
commits into
Pyomo:main
Choose a base branch
from
shermanjasonaf:pyros-vars-as-params
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+685
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o into pyros-vars-as-params
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
=======================================
Coverage 88.71% 88.72%
=======================================
Files 882 882
Lines 100622 100650 +28
=======================================
+ Hits 89271 89304 +33
+ Misses 11351 11346 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Motivated by recent user feedback, this PR adds support for the speciifcation of
Var
andVarData
objects as (entries of) the argumentuncertain_params
tocontrib.pyros.PyROS.solve()
. Thus, the argumentuncertain_params
can now be aParam
,ParamData
,Var
, orVarData
instance, or an iterable sequence of such instances.Note that if
uncertain_params
is of typeVar
/VarData
, or otherwise hasVar
orVarData
entries, then there may be an appreciable computational overhead during the PyROS solver preprocessing step for models with large numbers ofConstraint
,Expression
, and/orObjective
components in which theVar
/VarData
objects appear.Changes proposed in this PR:
Var
andVarData
objects inuncertain_params
argumentTODO (after #3434 merged)
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: