Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend valid types for PyROS solver argument uncertain_params #3439

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

shermanjasonaf
Copy link
Contributor

@shermanjasonaf shermanjasonaf commented Nov 30, 2024

Summary/Motivation:

Motivated by recent user feedback, this PR adds support for the speciifcation of Var and VarData objects as (entries of) the argument uncertain_params to contrib.pyros.PyROS.solve(). Thus, the argument uncertain_params can now be a Param, ParamData, Var, or VarData instance, or an iterable sequence of such instances.

Note that if uncertain_params is of type Var/VarData, or otherwise has Var or VarData entries, then there may be an appreciable computational overhead during the PyROS solver preprocessing step for models with large numbers of Constraint, Expression, and/or Objective components in which the Var/VarData objects appear.

Changes proposed in this PR:

  • Allow PyROS solver to support Var and VarData objects in uncertain_params argument

TODO (after #3434 merged)

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (eb8a6b5) to head (c372d98).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3439   +/-   ##
=======================================
  Coverage   88.71%   88.72%           
=======================================
  Files         882      882           
  Lines      100622   100650   +28     
=======================================
+ Hits        89271    89304   +33     
+ Misses      11351    11346    -5     
Flag Coverage Δ
linux 86.18% <100.00%> (+<0.01%) ⬆️
osx 76.21% <100.00%> (+0.01%) ⬆️
other 86.69% <100.00%> (+0.01%) ⬆️
win 84.66% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants