Update findseq for multiple objects #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2025 23:10
… is selected in all objects
|
Hi, thank you! Can you resolve this branch conflict before we test it? |
|
Hi! This is my first commit so I am not sure which conflict should be resolved. I see that the changes could be merged cleanly: Thanks! |
|
I'm seeing this I'll analyze better from 16/Jun forwards. |
|
@JarrettSJohnson and @speleo3, what do you see? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Findseq worked incorrectly when haystack spans multiple objects. In this case, the same residue IDs selected in all haystack objects.
Proposed change iterates over all objects in haystack and searches needle in each of them independently and finally combines them into the single search object.