Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nlpo3-python]: Allow unreachable code during test #77

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[nlpo3-python]: Allow unreachable code during test #77

wants to merge 8 commits into from

Conversation

bact
Copy link
Member

@bact bact commented Nov 10, 2024 •
edited
Loading

Set RUSTFLAGS = -A unreachable_code environment for cargo test to suppressed "unreachable code" errors/warnings

  • They are warnings, still able to successfully built, in my local environment

    stable-x86_64-apple-darwin (default)
    rustc 1.82.0 (f6e511eec 2024-10-15)

  • The same warnings are converted to errors in "cargo test" in the CI and made the build/test failed (see this run for example)

I'm not sure if this flag setting is a good practice.

Will the code still not able to build elsewhere?

@bact
Allow unreachable code during test
ab7a91d 
set RUSTFLAGS = "-A unreachable_code" when cargo test
@bact bact mentioned this pull request Nov 10, 2024
Closed
@bact bact requested review from wannaphong and Gorlph November 10, 2024 11:01
@bact bact added the help wanted Extra attention is needed label Nov 10, 2024
@bact bact changed the title Allow unreachable code during test [nlpo3-python]: Allow unreachable code during test Nov 10, 2024
@bact bact added the infrastructure CI/CD workflow, build, publication, deploy label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong Awaiting requested review from wannaphong

@Gorlph Gorlph Awaiting requested review from Gorlph

Assignees
No one assigned
Labels
help wanted Extra attention is needed infrastructure CI/CD workflow, build, publication, deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bact