Fix: Correct parameter unpacking in DeviceModel.clone to resolve TypeError #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cloning a
DeviceModel
instance was causing aTypeError
due to incorrect handling ofself._parameters
. TheDeviceModel.clone
method passedself._parameters
as a single positional argument instead of unpacking it as keyword arguments.Solution
DeviceModel.clone
method to unpackself._parameters
using**self._parameters
.DeviceModel.__init__
, which expects**parameters
as input.Netlist.copy_to
correctly uses the updatedclone
method to avoid errors during circuit cloning.Related Error
Steps to Test
Provide a quick guide for reviewers to test the fix: