slurm 24.05.X support #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code compiles amd I can run our python slurm utils. For now I have disabled the `epilog|prolgo' cconfigs they have changed for `char *` tp `char **`. Could not find a function for it so that is still on the todo list
so epilog/prolog//prolog_slurmctld/epilog_slurmctld working again
|
thank you for this. I will check it out soon in more detail, but looks good on a first quick glance. |
|
@basvandervlies: Thanks ! |
|
Awesome @basvandervlies ! Thanks! |
Merged
|
Sorry that it took so long to respond here. I made a new PR (#348) based on this one with some additional fixes, which is now merged into main. Thanks again @basvandervlies for working on it! :) |
|
No problem it is done and you improved it ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code compiles and I can run our python slurm utils. For now I have disabled the
epilog|prolog' configs they have changed fromchar *tochar **`. Could not find a function for it. So that is still on the todo list