Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated add_biochar_pyrolysis (closes #171) #176

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BertoGBG
Copy link
Contributor

@BertoGBG BertoGBG commented Feb 5, 2025

Closes #171

Changes proposed in this Pull Request

update functions biochar pyrolysis. fixed error in investment cost and converted all units to tCO2e sequestered

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you highlight the unit changes in the release notes as a breaking change? I think it's ok as the feature is quite new, but generally we want to avoid units changing back and forth between versions.

Also please merge the upstream master and run compile_cost_assumptions once again. Thx!

removed print flag for publications
@fneum
Copy link
Member

fneum commented Mar 6, 2025

Great, now it's just about resolving the merge conflicts and documenting the unit change in the release notes @BertoGBG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants