Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove highspy pin #1528

Merged
merged 4 commits into from
Feb 6, 2025
Merged

remove highspy pin #1528

merged 4 commits into from
Feb 6, 2025

Conversation

lkstrp
Copy link
Member

@lkstrp lkstrp commented Feb 4, 2025

Closes #1530
Ref #1531

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: no_logs_found
  • lkstrp-patch-3 failed in: no_logs_found

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing lkstrp-patch-3 (e04f3e7) with master (be7b9c6).
Branch is 4 commits ahead and 3 commits behind.
Last updated on 2025-02-06 16:37:22 CET.

@fneum
Copy link
Member

fneum commented Feb 6, 2025

Should 1.8 be blocked? This was the version that caused problems right?

@lkstrp
Copy link
Member Author

lkstrp commented Feb 6, 2025

1.9 made some problems at some point as well. Not sure if this was because of sub dependencies or something else.

Also, our blocked dependencies are not complete at all. And this is a conda env, not a package dependency list, so it will not be installed in other environments and blocking old versions will not make much difference anyway.

I think it's fine to not block old versions and reference the pinned env

@FabianHofmann
Copy link
Contributor

ah, you tackled the jupyter issue here already, could you add entsoe-py as well as done in #1531?

@lkstrp lkstrp merged commit d28cda6 into master Feb 6, 2025
14 checks passed
@lkstrp lkstrp deleted the lkstrp-patch-3 branch February 6, 2025 16:04
@lkstrp lkstrp mentioned this pull request Feb 6, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Jupyter to environment
3 participants