Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix industrial demand for ammonia when endogenously modelled #1312

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

koen-vg
Copy link
Contributor

@koen-vg koen-vg commented Sep 19, 2024

In calculating industrial energy demand today, demand for ammonia must be resolved into just "ammonia" when endogenously modelled, or into electricity and hydrogen if not. Before this fix, energy demand for ammonia was double-counted at current and near-term planning horizons when sector['ammonia'] = True; both in terms of ammonia and in terms of electricity and hydrogen.

While not incredibly large in magnitude, hydrogen demand at 2025 planning horizon was essentially double what it should have been before this fix.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

In calculating industrial energy demand today, demand for ammonia must
be resolved into just "ammonia" when endogenously modelled, or into
electricity and hydrogen if not.
@fneum
Copy link
Member

fneum commented Sep 20, 2024

Great! I'll do a small follow-up so that tests for Windows and MacOS run through (the snakemake object is lost in the multiprocessing). The dev test is failing because of some breaking changes in powerplantmatching that need to be addressed in PyPSA-Eur, so that's ok.

@fneum fneum merged commit 81da685 into PyPSA:master Sep 20, 2024
7 of 10 checks passed
fneum added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants