Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate: unchunk spatial dimension before apply_ufunc #326

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

FabianHofmann
Copy link
Contributor

Closes #324

Motivation and Context

compat with new xarray version 2023.09.00

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2555d81) 72.31% compared to head (be66fc0) 72.33%.

❗ Current head be66fc0 differs from pull request most recent head 104d252. Consider uploading reports for the commit 104d252 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   72.31%   72.33%   +0.01%     
==========================================
  Files          19       19              
  Lines        1694     1695       +1     
  Branches      294      294              
==========================================
+ Hits         1225     1226       +1     
  Misses        387      387              
  Partials       82       82              
Files Coverage Δ
atlite/aggregate.py 75.00% <100.00%> (+2.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FabianHofmann
Copy link
Contributor Author

@euronion I took the freedom to uncomment the change logs for the upcoming version

@FabianHofmann FabianHofmann merged commit 9ea305e into master Oct 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with convert_and_aggregate for long timespans?
2 participants