-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump supported cpython version to 3.14 for testing #4811
Open
clin1234
wants to merge
39
commits into
PyO3:main
Choose a base branch
from
clin1234:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
8efb65b
Add news item
clin1234 2aa43a2
Move news file
clin1234 4d0589f
Fix version limit check in noxfile.py
clin1234 5df3b1c
Bump Python version for testing debug builds
clin1234 ad3cfbd
3.14 is available from GH's setup-python action
clin1234 92ea50d
Bump maximum supported CPython version in pyo3-ffi
clin1234 24a1075
Rework PyASCIIObject and PyUnicodeObject to be compatible with 3.14
clin1234 49342e6
Run `cargo fmt --all`
clin1234 9ae3e4a
Actually add Py_3_14 as a legitimate macro
clin1234 7556d93
Revert "Actually add Py_3_14 as a legitimate macro"
clin1234 620e057
Fix version macro placement for 3.14-specific getters and setters
clin1234 cccc39c
Import 'c_ushort' only if compiling against CPython 3.14 or later
clin1234 d17c4ca
Add wrapper functions for the statically_allocated field
clin1234 5c83c39
Remove unused libc::c_ushort
clin1234 c6e70c5
Add (hopefully) final version-specific macros
clin1234 107c45d
Port 3.14-specific 64-bit code of Py_INCREF
clin1234 13014bf
Don't expose PyDictObject.ma_version_tag when building against 3.14 o…
clin1234 b7bd90a
fix ffi-check on the GIL-enabled ABI
ngoldbaum 4535892
fix older pythons
ngoldbaum e22fdc2
fix ffi-check on older pythons
ngoldbaum 901d623
WIP: update for 3.14t
ngoldbaum 1753d95
fix ffi-check on the free-threaded build
ngoldbaum b32adfa
fix clippy
ngoldbaum 16732d8
fix clippy on older python versions
ngoldbaum 52d9799
fix cargo check on the MSRV
ngoldbaum 78a3b6e
fix ffi-check on 3.13t
ngoldbaum 9f664fd
fix CI which is using 3.13.1
ngoldbaum c40011d
fix copy/paste error in noxfile
ngoldbaum 632288a
update ffi bindings for the latest changes in 3.14
ngoldbaum 46a9ccd
update layout of refcnt field on gil-enabled build
ngoldbaum 3dd439d
delete unused HangThread struct
ngoldbaum e72ce59
fix ffi-check on GIL-enabled build
ngoldbaum b25dd5a
Revert "delete unused HangThread struct"
ngoldbaum 0bc929f
config-out HangThread
ngoldbaum 08baf67
fix 3.13 ffi-check
ngoldbaum d4f75e2
fix debug python build error
ngoldbaum 5c306a7
fix graalpy build
ngoldbaum 529ceee
Ignore DeprecationWarnings from the pytest_asyncio module in tests
clin1234 514ce4f
Add abi3-py314
clin1234 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Bump supported cpython version to 3.14 for testing |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidhewitt for the suggestion, this worked like a charm. I don't see a callback API to override struct member names, so I had to leave the hack in the macro for the
ob_refcnt
field, but this lets us generate the names that pyo3-ffi expects for the type names I override below.