Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to mark various generated code with #[automatically_derived] #3994

Closed
wants to merge 2 commits into from

Conversation

alex
Copy link
Contributor

@alex alex commented Mar 26, 2024

fixes #3989

@alex
Copy link
Contributor Author

alex commented Mar 26, 2024

Haven't verified this is sufficient yet, just putting it up here for visibility.

@alex alex force-pushed the automatically-derived branch from 672e23a to 937fbb1 Compare March 26, 2024 11:35
@alex alex force-pushed the automatically-derived branch from 9658ef0 to 1f0f7fd Compare March 26, 2024 11:49
@alex
Copy link
Contributor Author

alex commented Mar 26, 2024

@davidhewitt on deeper review, I don't think this is going to work. My read of https://github.com/rust-lang/rust/pull/120185/files suggests that it only works on methods from impl blocks which are marked, it won't work on free-functions that #[pyfunction] generates.

@davidhewitt
Copy link
Member

Ah, that's frustrating.

I think the best hope for debugging in that case is to trigger a cryptography CI run with one or more of the #[pyfunction]s with coverage issues replaced by its expanded form from cargo expand. Hopefully that will show us what's not covered so we can think how to improve this.

@alex alex closed this Mar 27, 2024
@alex alex deleted the automatically-derived branch March 27, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyO3 v0.21 beta pyfunction annotation coverage
2 participants