-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"full" implementation of new Py2
API
#3606
Conversation
3235ef6
to
d4baf2a
Compare
CodSpeed Performance ReportMerging #3606 will degrade performances by 34.69%Comparing Summary
Benchmarks breakdown
|
bd4fbf3
to
cec5294
Compare
48244c9
to
9ed701d
Compare
205fb70
to
a852026
Compare
9693e6a
to
53e3f00
Compare
9ab55e9
to
0b9dd26
Compare
220ee43
to
3eb1a26
Compare
3eb1a26
to
c7d22cb
Compare
8ffb364
to
357558f
Compare
dad295a
to
c45427e
Compare
c45427e
to
c3d9e69
Compare
This branch has now outlived its usefulness. We've split out basically everything into other PRs, and I see no further need to keep trying to rebase this here for the few remaining odds and ends, so I'll close this. Great work everyone! |
Closes #3382
This branch has been used to implement pydantic/pydantic-core#1085
It's based on top of #3572, and also includes #3600 as well as updated forms of most of the other PRs introducing Py2 types.
I feel like this strikes a good balance of introducing the new
Py2
API without breaking much of the existing gil refs API. The only thing which really needed to change was theFromPyObject
trait, to take&Py2<'py, PyAny>
instead of&'py PyAny
. I don't think I'd want to land this amongst other breaking changes. I do think this might be releasable as an 0.22 release with both APIs still present (maybe gate the GIL refs API with abackcompat
feature), with a view to dropping the gil refs API in 0.24 maybe.Next steps:
We want to release
pydantic-core
against a form of this branch in the near future. Any opinions if I should release this as a fork of PyO3, or we release this as an 0.22 alpha?I plan to start splitting this out into reviewable PRs and keep this one rebased as we move forwards.
This also needs further cleanup / documentation etc.