-
Notifications
You must be signed in to change notification settings - Fork 833
Use CPython stable APIs for implementing tuples. #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How about making a single specific branch for this instead of merging series of PRs to the master? |
I personally find it easier to work in small PRs that can each be reviewed by themselves. This ensures that I'm constantly working off the latest version and didn't break anything. The next PR is probably going to be type definition support, which will be the biggest part of this anyways :-) |
Coverage change is because |
That patch would require careful design decisions and it's easier to work for me if we have an upstream branch for it. |
Yes, I agree that PR will be very subtle and require careful thought! Is it ok to review/merge this tuple PR as is, and then we can do a branch for the type definition work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, mostly LGTM.
Of course. I'll create |
Refs PyO3#1125 Reduces the number of compilation failures with `--features abi3` from 56 to 53.
Ok, should be good now! |
Now, https://github.com/PyO3/pyo3/tree/abi3 is available. |
Refs #1125
Reduces the number of compilation failures with
--features abi3
from 56 to 53.I chose to implement this by simple replacing all functions with their stable equivilant. This potentially regresses performance somewhat. If it's preferable, I can switch which call is used based on the
#[cfg]
at the price of some verbosity.