Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more iswap backend kwargs, hotel #343

Merged
merged 6 commits into from
Dec 27, 2024
Merged

Conversation

rickwierenga
Copy link
Member

No description provided.

@rickwierenga
Copy link
Member Author

rickwierenga commented Dec 27, 2024

changes:

added to STAR.pick_up_resource:

  • iswap_grip_strength: int = 4
  • minimum_traverse_height_at_beginning_of_a_command: Optional[float] = None
  • z_position_at_the_command_end: Optional[float] = None
  • plate_width_tolerance: float = 2.0
  • hotel_open_gripper_position: Optional[float] = None
  • hotel_depth=160.0
  • hotel_clearance_height=7.5
  • high_speed=False
  • plate_width: Optional[float] = None
  • use_unsafe_hotel: bool = False
  • iswap_collision_control_level: int = 0
  • iswap_fold_up_sequence_at_the_end_of_process: bool = True

added to STAR.drop_resource:

  • minimum_traverse_height_at_beginning_of_a_command: Optional[float] = None
  • z_position_at_the_command_end: Optional[float] = None
  • hotel_open_gripper_position: Optional[float] = None
  • hotel_depth=160.0
  • hotel_clearance_height=7.5
  • hotel_high_speed=False
  • use_unsafe_hotel: bool = False
  • iswap_collision_control_level: int = 0

the resource-tree update logic was moved form LiquidHandler.move_{plate,lid} into LiquidHandler.{pick_up,drop}_resource so that resources are put in the correct spots and the tree is accurate, also when the user doesn't use the highest levels methods. I am tempted to remove LiquidHandler.move_{plate,lid} because they only provide a default value for the parameter pickup_distance_from_top at this point (the default value can be in LiquidHandler.pick_up_resource instead.

I also deleted STAR.{iswap_pick_up_resource,iswap_release_picked_up_resource} and put the logic there into STAR.pick_up_resource and STAR.drop_resource. STAR.pick_up_resource and STAR.drop_resource now call the lowest-level firmware-command-implementations iswap_get_plate and iswap_put_plate, removing one layer (simple is better). This also allows the sharing of that logic with the hotel-variants of iswap commands.

@rickwierenga rickwierenga merged commit 731816f into main Dec 27, 2024
7 checks passed
@rickwierenga rickwierenga deleted the new-iswap-backend-kwargs branch December 27, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant