add Filter #342
Open
add Filter #342
+105
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
781
to
786
| if ( | ||
| isinstance(resource.parent, Plate) | ||
| and resource.parent.has_lid() | ||
| and not isinstance(resource.parent.lid, Filter) | ||
| ): | ||
| raise ValueError("Aspirating from a well with a non-filter lid is not supported.") |
There was a problem hiding this comment.
what do you think about making Filter inherit from Resource directly rather than Lid so that this check is not necessary?
pylabrobot/filters/filter.py
Outdated
Comment on lines
1
to
8
| from typing import Optional, Union | ||
|
|
||
| from pylabrobot.liquid_handling.liquid_handler import LiquidHandler | ||
| from pylabrobot.resources.carrier import ResourceHolder | ||
| from pylabrobot.resources.coordinate import Coordinate | ||
| from pylabrobot.resources.plate import Lid, Plate | ||
|
|
||
|
|
There was a problem hiding this comment.
wanna put this file in pylabrobot/resources/filter.py?
Comment on lines
1
to
5
| # Retro Filter V4 | ||
|
|
||
| <img src="RetroFilterV4.png" width="800" /> | ||
|
|
||
| Designed for flow cytometry prep. |
There was a problem hiding this comment.
shall i move this to the docs so it's on the website? i would add it under liquid handling in the user guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.