Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace m2r2 with sphinx-mdinclude #194

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Replace m2r2 with sphinx-mdinclude #194

merged 1 commit into from
Oct 8, 2024

Conversation

MarJMue
Copy link
Collaborator

@MarJMue MarJMue commented Oct 7, 2024

Fix for the current error during documentation generation:

sphinx-mdinclude is a newer fork of m2r2 and more actively developed.
Should work as drop-in replacement.

@MarJMue MarJMue requested a review from domna October 7, 2024 14:12
Copy link
Member

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this.

Maybe we should think about our rtd integration in the future. We have a CI build for PRs but it did not actually fail on this. Ideally, we would have an action which does a rtd test deploy so that we directly see if anything is failing before we do releases.

@MarJMue MarJMue merged commit 9e3d2fa into master Oct 8, 2024
12 checks passed
@MarJMue MarJMue deleted the sphinx-mdinclude branch October 8, 2024 10:49
@MarJMue MarJMue restored the sphinx-mdinclude branch October 8, 2024 10:49
@MarJMue MarJMue deleted the sphinx-mdinclude branch October 8, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants