Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job fair participation flag #644

Merged
merged 9 commits into from
Mar 13, 2018
Merged

Job fair participation flag #644

merged 9 commits into from
Mar 13, 2018

Conversation

ewdurbin
Copy link
Member

Flag for Job Fair Participation

Added a job_fair_participant BooleanField on the Sponsor model and make editable in Django Admin.

screen shot 2018-01-13 at 10 26 53 am

screen shot 2018-01-13 at 10 26 34 am

Auto generate Job Fair Participant/Table Listing

Dynamically generate an HTML table on the sponsors/jobs page with Sponsor name and their job_fair_table_number if the Sponsor is a job_fair_participant.

screen shot 2018-01-13 at 10 19 32 am

Smarter Templates for Sponsor Emails

Added Django Template functionality to Sponsor.send_email that allows for Django Template logic in Sponsor email sends... Hard to explain 😢

screen shot 2018-01-13 at 10 22 40 am

screen shot 2018-01-13 at 10 25 50 am

Non Participant:

screen shot 2018-01-13 at 10 28 40 am

Participant:

screen shot 2018-01-13 at 10 28 50 am

Address #643 #638

@ewdurbin
Copy link
Member Author

@ejodlowska @bwaliszewski Feedback welcome!!

@ewdurbin
Copy link
Member Author

Twitch Stream detailing all of this work end to end: https://www.twitch.tv/videos/218141251

@ejodlowska
Copy link
Contributor

@ewdurbin It looks good to me - very cool. The only issue I see is the list of job fair table #s is going to be a very long list (~60). Is there any way to have it on the right hand side next to the job ads?

@ewdurbin
Copy link
Member Author

@ejodlowska yes, indeed that is the plan! this was just all put together to sketch out the ideas. i plan to complete the layout shortly and add some tests :)

@ewdurbin
Copy link
Member Author

ewdurbin commented Jan 14, 2018

Updated Jobs Page :)

Table directory in a column on the right:

screen shot 2018-01-14 at 6 33 52 am

On narrow screens, the Job Fair directory stacks under the listings and a link to jump down the page appears ✨!

screen shot 2018-01-14 at 6 33 57 am

screen shot 2018-01-14 at 6 34 00 am

@ewdurbin
Copy link
Member Author

moved jump button above callout. assume it will be most used during job fair on mobile and would rather keep it top of page.
screen shot 2018-01-14 at 6 57 25 am

@ejodlowska
Copy link
Contributor

@ewdurbin Looks awesome! Thanks so much for working on this!

Issue #638 and #643 both relate to determining if a Sponsor is participating in the Job Fair or not!

This adds a Boolean that can annotate Job Fair Participation for each sponsor individually and exposes that in the the Django Admin.

PyCon staff can now explicitly set or unset Job Fair Participation so that we can auto generate the list of Job Fair Participants for #643 and hopefully expose the boolean for templates to contain different content for Sponsors who are and are not participating in the job fair.
Introduces Django's own templating language for more robust templates in sponsor emails.

Leaves existing %% based template logic in place, does a pass of Django's Template.render() at the end.

Currently only exposes JOB_FAIR_PARTICIPANT boolean.
@ewdurbin ewdurbin force-pushed the job_fair_participation_flag branch from a5f9ddf to 9b7b2a3 Compare March 13, 2018 23:36
@ewdurbin ewdurbin merged commit 892171c into develop Mar 13, 2018
@ewdurbin ewdurbin deleted the job_fair_participation_flag branch March 13, 2018 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants