Fix test for nightly Python (3.9) #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetterS
force-pushed
the
py39
branch
4 times, most recently
from
2397757 to
b03aaaf
Compare
|
OK, test passes now but feels way too brittle. Should be enough to assert that the error starts with |
asottile
reviewed
Apr 19, 2020
|
could you rebase this? it should be fixed upstream now |
|
Done! But the Travis check does not seem to have run for some reason. |
|
looks like the new PEG parser has broken these even further :( |
|
Drop these tests for nightly? Seem a little too fragile? |
|
the tests are valuable, and have pointed out a bug in cpython I think we'll probably |
|
OK, where is that setting? (Should probably move some version of these tests into CPython if they are useful in catching CPython bugs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get the nightly test in #530 to pass.