Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articulo de primera PyCon Colombia a la pagina principal en inglés y español #519

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

andoresuperesu
Copy link
Collaborator

Pull request

Articulo de primera PyCon Colombia a la pagina principal en inglés y español

Observaciones

Segun sugerido en conversación.

@pyjavo pyjavo self-requested a review June 20, 2024 22:50
@@ -68,7 +68,7 @@ source: testimonies
#### sponsors ####
title: OUR SPONSORS
----
source: sponsors
role: 1-patrocinador
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿A que se debe este cambio tanto en español como en inglés?

    - source: sponsors
    + role: 1-patrocinador

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supongo que es parte de los scripts que se ejecutan. Yo no hice ese cambio manualmente.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, eso son los diferentes roles de aliados, que pueden ser patrocinador o inactivo, ese cambio lo introduje yo, pero como no habia necesitado actualizar ese bloque no habia caido en cuenta

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andoresuperesu ahora que recuerdo, a mi también me sugirió ese cambio una vez pero yo no lo subí. ¿Puedes revertirlo manualmente por favor?
Es decir, que vuelva a decir source: sponsors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eso es un error mio, en realidad el valor que esta enviando andres es el correcto

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/PyBAQ/website/blob/master/templates/blocks/sponsors.html y esta la plantilla, el valor correcto es el suministrado aca, mejor dejalo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andoresuperesu @Scot3004 es importante tener eso claro y si está raro entonces se me ocurre lo abordemos en otro PR

Por ahora Andrés lo vuelva a dejar como estaba y sus imagenes ya quedarian listas ¿qué opinan?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es algo que genera lektor, deshacerlo seria un retrabajo innecesario, especialmente dado que es auto-generado

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entiendo

@pyjavo pyjavo self-requested a review June 20, 2024 23:24
@pyjavo pyjavo merged commit 68e4cdf into PyBAQ:master Jun 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants