Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOs runners now that Apple Silicon is native #94

Merged
merged 5 commits into from
May 22, 2024

Conversation

jlaine
Copy link
Member

@jlaine jlaine commented May 22, 2024

No description provided.

GitHub actions now provides native runners:

- For arm64, using macOs 14
- For x86_64, using macOs 13
fontconfig 2.13.1 crashes on macOs / arm64 during install:

    fc-cache -s -f -v
      /bin/sh: line 1: 67772 Segmentation fault: 11  fc-cache/fc-cache -s -f -v
This should fix the error:

  ld: building exports trie: duplicate symbol '_av_ac3_parse_header'
Even though we disable XCB support in FFmpeg, somehow the X11 libraries
still end up linked into the build, resulting in errors:

    delocate.libsana.DelocationError: Library dependencies do not satisfy target MacOS version 11.0:
      [..]/libXdmcp.6.dylib has a minimum target of 14.0
      [..]/libXau.6.0.0.dylib has a minimum target of 14.0
      [..]/libX11.6.dylib has a minimum target of 14.0
      [..]/libxcb.1.1.0.dylib has a minimum target of 14.0
@jlaine
Copy link
Member Author

jlaine commented May 22, 2024

@WyattBlue this PR is not trivial, but we really need it. We can no longer use macos-latest, because this breaks both our arm64 and x86_64 builds.

  • The old meaning of macos-latest was macOs 13 on x86_64 : x86_64 was a native build, arm64 was a cross-build.
  • The new meaning of macos-latest is macOs 14 on arm64.

This means the cleanest and fastest setup is now:

  • use macos-14 for native arm64 builds.
  • use macos-13 for native x86_64 builds. I suspect at some point in the future we will drop this completely, Apple isn't going to support Intel processors forever.

@jlaine jlaine merged commit e86ee37 into PyAV-Org:main May 22, 2024
7 checks passed
@jlaine jlaine deleted the macos-runners-x branch May 22, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant