fix: fix all question having the same letter answer in tests

PupoSDC · Aug 3, 2023 · 3acabec · 3acabec · vercel · Aug 3, 2023
1 parent 5b21b27
commit 3acabec
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/apps/next-app/pages/questions/[questionId]/components/edit-question-body.tsx b/apps/next-app/pages/questions/[questionId]/components/edit-question-body.tsx
@@ -36,7 +36,6 @@ export const EditQuestionBody: FunctionComponent = () => {
       </FormControl>
       <HookFormTextArea
         {...form.register("question.explanation")}
-        name={"question.explanation"}
         minRows={5}
         sx={{ mt: 1 }}
       />

diff --git a/apps/next-app/pages/questions/[questionId]/edit.page.tsx b/apps/next-app/pages/questions/[questionId]/edit.page.tsx
@@ -40,7 +40,11 @@ export const EditQuestionPage: NextPage = () => {
     },
   };
 
-  const form = useForm({ resolver, defaultValues, mode: "onBlur" });
+  const form = useForm<EditQuestionFormValues>({
+    resolver,
+    defaultValues,
+    mode: "onBlur",
+  });
 
   return (
     <>

diff --git a/libs/core/app/src/tests/create-test.ts b/libs/core/app/src/tests/create-test.ts
@@ -1,6 +1,10 @@
 import { z } from "zod";
 import { getQuestion } from "../questions/get-question";
-import { getRandomId, getRandomShuffler } from "../random/random";
+import {
+  getRandomId,
+  getRandomIdGenerator,
+  getRandomShuffler,
+} from "../random/random";
 import type { Test, QuestionBankRepository } from "@chair-flight/base/types";
 
 export type NewTestConfiguration = {
@@ -53,6 +57,7 @@ export const createTest = async ({
   const title = config.title ?? `${subject} ${mode}`;
   const seed = config.seed ?? getRandomId();
   const shuffler = getRandomShuffler(seed);
+  const getRandomRandomId = getRandomIdGenerator(seed);
 
   const learningObjectives = Object.entries(config.learningObjectives).reduce<
     string[]
@@ -73,7 +78,7 @@ export const createTest = async ({
 
   const questions = shuffler(possibleQuestions)
     .slice(0, numberOfQuestions)
-    .map((q) => getQuestion(q, { seed }));
+    .map((q) => getQuestion(q, { seed: getRandomRandomId() }));
 
   return {
     id: getRandomId(),