Rename rayon worker threads #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously all threads were named
tokio-runtime-w. This PR renames all the rayon worker threads torayon-worker.This makes it more straightforward to profile the program (eg. flamegraph) as there is a distinction between rayon and tokio threads.
Also removed a random session.lock file that I figured got added by accident.
Testing
Start server using
cargo-flamegraph.Join the server and then stop it.
Look at the flamegraph to see
rayon-workerseperate fromtokio-runtime-w.Please follow our Coding Guidelines