-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: encode Uuid correctly (fixes #454) #583
Conversation
Ah leave the is_human_readable set to false though |
pub resource_pack_url: String, | ||
/// The SHA1 hash (40) of the resource pack. | ||
pub sha1: String, | ||
pub resource_pack_sha1: String, | ||
/// Custom prompt Text component, Leave blank for none | ||
pub message: String, | ||
pub prompt_message: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this, The Category is already named Resource so this is just duplicate naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @kralverde
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert
Description
Fixes #454 by properly configuring
uuid::Uuid
serialization. This also removes the need for#[serde(with = "uuid::serde::compact")]
across the codebase.Testing
features.toml
Please follow our Coding Guidelines