Fix deadlock when "packet ready" buffer is full #565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the send packet function is invoked on the client, the lock on the encrypter was unnecessarily held for the remainder of the function. When a notification was sent to the
server_packets_channel
, the encrypter lock was still held, preventing the serialized packet from being taken and blocking the next call to the send packet functionTesting
You can verify this worked by teleporting to the world border.
Before: Deadlock
Now: Normally chunk loading
Please follow our Coding Guidelines