-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully exit on stop, new logger and rustyline #557
Conversation
Would be great if you could somehow get spawn chunks to get saved as well |
Spawn chunks should be saved now @Snowiiii |
I noticed that log level is not colorful anymore, Any way to get the color back ? |
I'm also not fully sure about simplelog, Are there any other alternatives we can use ? |
Yeah, it has color settings |
Any logger that supports writing to file should work, but this is the only one I've found |
Colors should work now @Snowiiii |
This should also fix
When continuous running |
Looks good. I also noticed that the deadlock which happens sometimes on Join is fixed and also command arguments in Console. Thank you @kralverde |
Description
This PR gracefully exits on a
SIGXXX
signal orstop
command.Rustyline needed to be replaced with an async version because the originally was blocking and could not be interrupted, leaving the terminal in raw mode after the server terminated.
The logger needed to be updated to a logger that supports files to work with the new rusty line to pretty print logs while still having the user input.
Testing
Please follow our Coding Guidelines