Fix Item Tool Components and Partially Implement Tag Updates #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowiiii
reviewed
Feb 16, 2025
|
Also added a fluid extractor with Pumpkin-MC/Extractor#6 so swimming works |
|
Nice. Great work @kralverde 👍 |
urisinger
pushed a commit
to urisinger/Pumpkin
that referenced
this pull request
Feb 16, 2025
…-MC#554) * initial commit * add fluid tags * rename tag item * Don't broadcast block breaking to breaker --------- Co-authored-by: Alexander Medvedev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR partially implements tag updates to allow for block tags to be sent to the client. It also uses tags for tool components instead of a list of what the tags reference. With this, tools properly break blocks with different speeds.
With a
Fluidregistry extractor, this will also fix the "no swimming" issue in water.Testing
Please follow our Coding Guidelines