Implement experience and experiene/xp commands #521
+542
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason I am getting link errors
drakeerv
changed the title
Snowiiii
reviewed
Jan 31, 2025
pumpkin/src/entity/player.rs
Outdated
Comment on lines
140
to
145
| /// The player's experience level | ||
| pub experience_level: AtomicI32, | ||
| /// The player's experience progress (0.0 to 1.0) | ||
| pub experience_progress: AtomicCell<f32>, | ||
| /// The player's total experience points | ||
| pub total_experience: AtomicI32, |
There was a problem hiding this comment.
- I wonder if
experience_levelandtotal_experiencecan become unsigned since i'm not sure if you can get negative XP? - I don't really get the difference between
experience_levelandtotal_experience, I would suggest to improve the doc on these
Math WIP
drakeerv
changed the title
drakeerv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I implemented experience and the commands to control it (currently the only way to get experience).
Testing
Tested it in game and ran cargo fmt & clippy