Consider using Subchunks instead of ChunkBlocks #458
+1,784
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update mod.rs Update mod.rs Update mod.rs Update mod.rs
…nto simple-branch
|
all done |
rle enabled: 45mb mem usage rle disabled: 65mb mem usage
|
All done again |
Snowiiii
reviewed
Jan 6, 2025
Snowiiii
reviewed
Jan 6, 2025
Snowiiii
reviewed
Jan 6, 2025
|
Wil be cool if someone write a #462, or if someone add another compression methods like octree or paletted container with bitvec |
|
Why you just copied to rle-vec crate ?, If you don't know in rust we have |
I wanted make some changes but i idk why, i just zabil what i want to do Edit: vspomnil, rle dont have .get() method |
|
Maybe it can improve situation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What?
Yeah, i want structure chunk and make subchunks. Its a very cool optimization for chunk section, because its utilizes air and any other block.
Its a demo pr. Like its need discussions and optimizations, but can be merge now.
Its also can break some code, because its a game changer.
Testing
cargo run --releasesee whats its not crashing, i can place blocks normally
see memory usage on my branch
git checkout main
cargo run --release
see memory usage on main
think what it works
Please follow our Coding Guidelines