Made getting players by name case-insensitive #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still not sure about this, There was an PR for this recently #439. But i'm thinking about plugin devs may wanting to have the case checked |
|
wdym? not sure about making player arguments case insensitive in commands? or altering the function used to get players? I believe the player arguments in commands should be case-insensitive one way or another, as it is in Vanilla, otherwise, it would be an annoying inconvenience. |
|
I mean for arguments it's probably fine, just was thinking that someone many wants to match with case in the future. anyway. Thank you @RealVaprant 👍 |
|
ig on the next update you could just make a new function for not ignoring cases. Though I think for now, ignoring cases would be better for default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made the player name and the parameter lower case when matching them. This way, things like player arguments in commands don't need to be case-sensitive. Overall a revolutionary change.
Testing
Please follow our Coding Guidelines