fix: Usage of TextContent::Translate resulted in a bad packet

[jonasborsch]

Description

As a heads up, I've never developed in rust before, so please give me the hardest feedback you can.

The usage of TextContent::Translate resulted in a bad packet. This was due to the implementation causing the TextComponent's from the with vector to be serialized into a byte array. I would guess, that for the same reason the temporary struct was used.

I tried different solutions but the only viable for me seemed to be a wrapper. With that the whole temporary struct could be removed. The TextComponent now handles JSON-serialization and the TextComponentNbt is the NBT binary representation.

Testing

Now we can edit the assets/synced_registries.json file and we see that the /say command uses the correct translation.

[jonasborsch]

Feel free to review, but still a draft because there are still two things open:

1. Messages from the /say command do not appear in the console
2. Need to add tests for the TextComponent
3. My format is probably shit

[Snowiiii]

Really impressive for someone who just Started with Rust 👍. Your approche is similar to valence (which is not a bad thing). One thing you have to fix is the CI, In particulier some clippy checks are failing, make sure to fix every warning produced when running cargo clippy --all-targets

Overall good work, Thank you @jonasborsch

[jonasborsch]

Really impressive for someone who just Started with Rust 👍. Your approche is similar to valence (which is not a bad thing). One thing you have to fix is the CI, In particulier some clippy checks are failing, make sure to fix every warning produced when running cargo clippy --all-targets

Overall good work, Thank you @jonasborsch

Thanks for the feedback! If I knew there was already an implementation of that I could've saved couple hours of my time. 🥲

Anyway, I'll work on the fixes and then mark the PR as ready for review

[jonasborsch]

Had to add the assets/lang/en_us.json file to allow server logs to be translated. This PR turns out the be an implementation of chat type instead of the simple translate fix.

There is still some work left:

• easier use of chat types (maybe an enum?)
• (optional) use the provided arguments list of the chat decorators. Java uses a context and dynamically resolves the arguments from that context
• check if the pumpkin-core/src//lang/mod.rs is any good
• refactor to_pretty_console() (my first thought was Visitor-Pattern)

[Snowiiii]

All files in the assets are coming from our Extractor. Can you may modify the extractor so it produces the latest en-US.json

[jonasborsch]

All files in the assets are coming from our Extractor. Can you may modify the extractor so it produces the latest en-US.json

That‘s definitely more convenient. I will work on it in the next couple of days. Thanks for the tip

[jonasborsch]

All files in the assets are coming from our Extractor. Can you may modify the extractor so it produces the latest en-US.json

See Pumpkin-MC/Extractor#2