Initial work on handle use item #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowiiii
requested changes
Dec 30, 2024
|
We need to send sound, but its in future |
neeleshpoli
reviewed
Dec 31, 2024
Snowiiii
reviewed
Dec 31, 2024
|
All fixed, waiting review |
|
You need to use |
Snowiiii
reviewed
Jan 7, 2025
Comment on lines
+96
to
+101
| pub consume_seconds: f32, | ||
| pub has_consume_particles: bool, | ||
| pub animation: Option<String>, | ||
| pub sound: Option<String>, | ||
| // TODO: Effects implementation?? | ||
| pub on_consume_effects: Option<Vec<serde_json::Value>>, |
There was a problem hiding this comment.
Please, Before changing anything in the item_registry and trying to just look at the JSON what vanilla does just open up the vanilla Implementation. The Consumable component can be found in net.minecraft.component.type::ConsumableComponent
- consume_seconds: optional float
- animation: optional enum
- sound: optional SoundEvent
- has_consume_particles: optional bool
- on_consume_effects: optional list of "ConsumeEffect"s
There was a problem hiding this comment.
But some items have default values, like consume srxonds, its 1.6 by default, and why i need to add options if it has a default value?
There was a problem hiding this comment.
Some food dont have any arguments, so where i can get consume seconds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial work on handle use item, also i add strip in cargo.toml for optimizations.
Testing
cargo test
cargo run
see world
Please follow our Coding Guidelines