Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heritage tree update #99

Closed
wants to merge 13 commits into from
Closed

heritage tree update #99

wants to merge 13 commits into from

Conversation

emillipede
Copy link
Contributor

@emillipede emillipede commented May 15, 2020 •
edited
Loading

addresses #98

Motivation and context

heritage tree documentation is a priority for the city. this PR adds:

  • information about newly-designated heritage trees. at the end of 2019, the city designated 5 more heritage trees. I added them to the csv.
  • photos of the first four heritage trees. Dave Baoicchi, a local photographer, has shared his heritage tree photos with the project.
  • what's the simplest way to display these photos to users see when they open the information panel to learn more about the heritage trees?
  • should they become part of download-images.js?
  • could these images go into the existing heritage_trees.csv?
  • easiest to load them on the front end? there are 20 heritage trees / 35,000 public trees. best to do whatever is simplest.

What I did

  • I added a folder for heritage tree photos. I added photos of the first 4 heritage trees, with the heritage numbers and tree IDs in the image file names.
  • I added rows for 5 more heritage trees, and I included the newly-designated heritage trees' tree ID numbers in the csv

@emillipede
add 2019 heritage trees
87fc67b 
still needs: 

- heritage tree numbers for each tree ID (which tree corresponds to which heritage number 16-20) 
- tree ID for Magnolia grandiflora at 502 alta (either 10925650 or 10925651)
- tree ID for Eucalyptus camaldulensis from palisades park (I can likely go in person to determine the ID - there are 7 red gum trees near each other in the park, the new heritage tree is visually distinctive)
@emillipede
add column to new heritage trees
0034eea
@emillipede emillipede changed the title 2019 heritage heritage tree update May 15, 2020
@emillipede
Copy link
Contributor Author

emillipede commented May 21, 2020 •
edited
Loading

@cajaks2 and @Cdower recommend resizing the images to ~ 800 x 800. I updated the folder in this PR with smaller images

@emillipede emillipede requested a review from Cdower May 21, 2020 04:00
@emillipede emillipede added the enhancement New feature or request label May 24, 2020
@emillipede emillipede mentioned this pull request May 27, 2020
Open
@emillipede
Copy link
Contributor Author

closing - I need to add files in a different way (cf #98)

@emillipede emillipede closed this May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainrandom captainrandom Awaiting requested review from captainrandom

@cajaks2 cajaks2 Awaiting requested review from cajaks2

@Cdower Cdower Awaiting requested review from Cdower

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emillipede