Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQs.md with section on installing {gt} #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

terrymclaughlin
Copy link
Contributor

Pull Request Details

Provides details of why the latest version of the {gt} package will not install and work as expected on Posit Workbench and links to the posit-workbench-install-gt repo that contains detailed installation instructions for v0.5.0 of {gt} and all of its dependencies.

Issue Number: #13

Type: Documentation

Description of the Change

See pull request details above.

Verification Process

John Wood and I have tested that the installation script works correctly.

Additional Work Required

None.

Release Notes

Update FAQs with section on installing the {gt} package

Link to the posit-workbench-install-gt repo with detailed installation instructions.
@terrymclaughlin terrymclaughlin linked an issue Mar 23, 2023 that may be closed by this pull request
@terrymclaughlin terrymclaughlin self-assigned this Mar 23, 2023
@terrymclaughlin terrymclaughlin added the documentation Improvements or additions to documentation label Mar 23, 2023
Copy link
Member

@rmccreath rmccreath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @terrymclaughlin - in terms of the FAQ update, looks good.

I'm wondering that if we're going to have supporting code-chunks that we should define a process for that, preventing repos being opened and end up with it difficult to maintain/manage. This could maybe be sections within docs (i.e. a How to install packages doc), or a directory of code chunks within this repo?

@@ -18,6 +18,12 @@ If you are working remotely, yes: ensure that when you login to Windows that you

### Installing Packages

#### How do I install the `{gt}` package?

Versions of the [`{gt}`](https://gt.rstudio.com/) package, up to and including v0.5.0, use [PhantomJS](https://phantomjs.org/) (a scriptable headless browser) to take screenshots of tables produced by `{gt}`. Newer versions ot `{gt}` require a Chromium-based browser which is not yet configured correctly in the Posit Workbench environment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Versions of the [`{gt}`](https://gt.rstudio.com/) package, up to and including v0.5.0, use [PhantomJS](https://phantomjs.org/) (a scriptable headless browser) to take screenshots of tables produced by `{gt}`. Newer versions ot `{gt}` require a Chromium-based browser which is not yet configured correctly in the Posit Workbench environment.
Versions of the [`{gt}`](https://gt.rstudio.com/) package, up to and including v0.5.0, use [PhantomJS](https://phantomjs.org/) (a scriptable headless browser) to take screenshots of tables produced by `{gt}`. Newer versions of `{gt}` require a Chromium-based browser which is not yet configured correctly in the Posit Workbench environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQ - How do I install the {gt} package?
3 participants