-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add activity after death #953
Conversation
This was causing NSUs to show a social care id. This now resolves this.
This reverts commit 004e831.
@SwiftySalmon spotted an issue where NSUs were showing a social care id attached. This was due to us matching on NSUs first and then SC Client variables at the end. Previously we matched SC client variables first and then NSUs onto the episode file. This difference occurred when we split up matching on client variables at the year specific extracts. This is a quick PR to reorder the functions to match our previous logic. I have tested the 1920 file to check this and the issue is no longer there.
Improved the function `create_demog_test_flags` function to include a parameter for specifying `chi` or `anon_chi`. This is due to this function being used for testing the extracts (which calls chi) and also being used for testing the episode and individual file (which calls anon_chi). This now allows flexibility for interchanging between the two forms and simplifies the code by removing duplicated code. Closes #850
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks fine! Need to run it tomorrow and see how the output looks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jennit07 <[email protected]>
Co-authored-by: Jennit07 <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (10)anu To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/9256605888/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (272) from .github/actions/spelling/expect.txt and unrecognized words (10)
Consider adding them (in with:
extra_dictionaries:
cspell:k8s/dict/k8s.txt
cspell:swift/src/swift.txt
cspell:npm/dict/npm.txt
cspell:csharp/csharp.txt
cspell:filetypes/filetypes.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' If the flagged items are 🤯 false positivesIf items relate to a ...
|
Related to #862
WIP - Added function for get_all_slf_deaths_lookup_path which combines all financial years' extract.
- Added function for add_activity_after_death_flag
Following identification of activity recorded after death due to data quality or admin issues, an investigation into sources of death data available for SLFs was undertaken. This guided the addition of a new variable to flag records where activity occurred after the death of date. Further details about the issues and methodology can be found in the accompanying "Investigation into activity after death" report.