-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop high level tests across years #951
Conversation
Uses SLFhelper for easy access to Source_Linkage_Files
WIP - still need to add write to disk and possibly develop visuals
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
), | ||
tar_target( | ||
cross_year_tests, | ||
process_tests_cross_year(year = year) | ||
), # , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i need to come back to this as im not sure this will ensure that all newly created ep files will be included in the test comparison
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine. We'll run it and see how it goes
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (2)Fhelper To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/9190411632/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (272) from .github/actions/spelling/expect.txt and unrecognized words (2)
Consider adding them (in with:
extra_dictionaries:
cspell:swift/src/swift.txt
cspell:k8s/dict/k8s.txt
cspell:fullstack/dict/fullstack.txt
cspell:csharp/csharp.txt
cspell:filetypes/filetypes.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' If the flagged items are 🤯 false positivesIf items relate to a ...
|
WIP - just need to write to disk for the June update.
I think this can be developed further with some visualisations!