Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - HL1 filtering to east ayrshire data only in 22/23 #931

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Jennit07
Copy link
Collaborator

@Jennit07 Jennit07 commented Mar 22, 2024

Due to a bug in the file, the 22/23 file was filtering data for east ayrshire only. This is due to an error with matching to the SG completeness file. Improvements to the code here is necessary as this was not picked up in the automated process and was a manual change when this file updated. This is related to the issue #906

The episode and individual files for 22/23 need to be re-ran to correct this.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 13
ℹ️ no-newline-at-eof 1

See ❌ Event descriptions for more information.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (235) from .github/actions/spelling/expect.txt and unrecognized words (0)

Dictionary Entries Covers Uniquely
cspell:csharp/csharp.txt 32 1
cspell:swift/src/swift.txt 53 1
cspell:filetypes/filetypes.txt 264 1
cspell:npm/dict/npm.txt 302 1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:csharp/csharp.txt
          cspell:swift/src/swift.txt
          cspell:filetypes/filetypes.txt
          cspell:npm/dict/npm.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''

Copy link
Collaborator

@SwiftySalmon SwiftySalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@SwiftySalmon SwiftySalmon reopened this Mar 26, 2024
@SwiftySalmon SwiftySalmon merged commit 2762e3d into mar-23-update Mar 26, 2024
14 of 17 checks passed
@SwiftySalmon SwiftySalmon deleted the hl1_investigation branch March 26, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants