SC Demographics and SDS

[SwiftySalmon]

Complete rewrite of SC Demographics.

Changes include:

• only using chi from chi,
• filling missing chi in if possible,
• latest submissing is no longer accurate, so added code to choose the latest and made changes to replace_sc_id_with_latest function
• now selects latest sc id across all social care sections, not just whatever section is being run. will be consistent across sds, ch, hc, and at (hopefully)
• cases where chi is missing were previously assigned the same social care id. This is fixed so it's a unique social care id allowing analysis to be done with these cases if needed.

Things not fixed:

• multiple chis per social care id. Data Management aware and working on it
• cases where start date is after period end date get removed in SDS (n = 4) These one are up to DM to contact local authority and as to resubmit

I checked sds output against the social care publication and I am happy with it. Obviously demographics code might change again once I look at other sections.

[Jennit07]

Made a few comments, I was confused in some points of the code so just made a few comments as i went along. Posit was really slow for me today but i managed to run through the code and it was all working

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (3)

commiting
stylr
submissing

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the social-care-investigation branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7816301070/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (235) from .github/actions/spelling/expect.txt and unrecognized words (3)

Dictionary	Entries	Covers	Uniquely
cspell:k8s/dict/k8s.txt	153	1
cspell:npm/dict/npm.txt	302	1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:k8s/dict/k8s.txt
          cspell:npm/dict/npm.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''

Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spelling/patterns.txt:

# Automatically suggested patterns
# hit-count: 6 file-count: 2
# Compiler flags
(?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,})

Errors (3)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
ℹ️ candidate-pattern	2
❌ ignored-expect-variant	13
ℹ️ no-newline-at-eof	1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[Jennit07]

Ran through the code and it works fine. Logic looks good. Happy to approve/merge!