Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review create_demog_test_flags function #898

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

Jennit07
Copy link
Collaborator

Improved the function create_demog_test_flags function to include a parameter for specifying chi or anon_chi. This is due to this function being used for testing the extracts (which calls chi) and also being used for testing the episode and individual file (which calls anon_chi). This now allows flexibility for interchanging between the two forms and simplifies the code by removing duplicated code.

Closes #850

@Jennit07 Jennit07 added the enhancement New feature or request label Jan 22, 2024
@Jennit07 Jennit07 self-assigned this Jan 22, 2024

This comment has been minimized.

SwiftySalmon
SwiftySalmon previously approved these changes Jan 24, 2024
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

consulations
SPSS

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the review_demog_test_flags branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7642310906/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (235) from .github/actions/spelling/expect.txt and unrecognized words (2)

Dictionary Entries Covers Uniquely
cspell:csharp/csharp.txt 32 1
cspell:swift/src/swift.txt 53 1
cspell:filetypes/filetypes.txt 264 1
cspell:npm/dict/npm.txt 302 1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:csharp/csharp.txt
          cspell:swift/src/swift.txt
          cspell:filetypes/filetypes.txt
          cspell:npm/dict/npm.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''
Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 13
ℹ️ no-newline-at-eof 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link
Collaborator

@SwiftySalmon SwiftySalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test but looks fine

@SwiftySalmon SwiftySalmon merged commit 3233bfb into mar-23-update Jan 24, 2024
11 of 12 checks passed
@SwiftySalmon SwiftySalmon deleted the review_demog_test_flags branch January 24, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants