-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review check_qtr_format
function
#897
Conversation
This reverts commit 004e831.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Quarter calculation functions we need to review if they are needed. Currently used in care home methodology used to calculate stay. Script: get_fy_quarter_dates.R
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ready for review/merge |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (3)beddays To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7931646654/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (235) from .github/actions/spelling/expect.txt and unrecognized words (3)
Consider adding them (in with:
extra_dictionaries:
cspell:k8s/dict/k8s.txt
cspell:lorem-ipsum/dictionary.txt
cspell:scala/dict/scala.txt
cspell:npm/dict/npm.txt
cspell:dotnet/dict/dotnet.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Errors (2)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this Jen. This looks good to me, I'm happy to merge.
Opening a draft PR for now. I think we need to review the care home methodology before deciding if we need the quarter calculation functions. I will highlight areas in the code which i am not sure about as i want to make sure we pick up the correct logic.
For now i have concluded that we can remove the
check_qtr_format
function so have removed this from the code.Closes Issue #886