Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review check_qtr_format function #897

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Conversation

Jennit07
Copy link
Collaborator

@Jennit07 Jennit07 commented Jan 22, 2024

Opening a draft PR for now. I think we need to review the care home methodology before deciding if we need the quarter calculation functions. I will highlight areas in the code which i am not sure about as i want to make sure we pick up the correct logic.

For now i have concluded that we can remove the check_qtr_format function so have removed this from the code.

Closes Issue #886

This comment has been minimized.

This comment has been minimized.

R/create_individual_file.R Outdated Show resolved Hide resolved
@Jennit07
Copy link
Collaborator Author

Quarter calculation functions we need to review if they are needed. Currently used in care home methodology used to calculate stay.

Script: get_fy_quarter_dates.R

  • start_fy_quarter
  • end_fy_quarter
  • start_next_fy_quarter
  • end_next_fy_quarter

This comment has been minimized.

This comment has been minimized.

@Jennit07 Jennit07 added the On hold Waiting for something / someone outside of our control label Feb 6, 2024
@Jennit07 Jennit07 marked this pull request as ready for review February 16, 2024 13:59

This comment has been minimized.

@Jennit07 Jennit07 removed the On hold Waiting for something / someone outside of our control label Feb 16, 2024
@Jennit07
Copy link
Collaborator Author

Ready for review/merge

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (3)

beddays
dnas
hri

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the review_check_qtr_format branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7931646654/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (235) from .github/actions/spelling/expect.txt and unrecognized words (3)

Dictionary Entries Covers Uniquely
cspell:k8s/dict/k8s.txt 153 2 1
cspell:lorem-ipsum/dictionary.txt 243 1 1
cspell:scala/dict/scala.txt 153 1
cspell:npm/dict/npm.txt 302 1
cspell:dotnet/dict/dotnet.txt 405 1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:k8s/dict/k8s.txt
          cspell:lorem-ipsum/dictionary.txt
          cspell:scala/dict/scala.txt
          cspell:npm/dict/npm.txt
          cspell:dotnet/dict/dotnet.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''
Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 13
ℹ️ no-newline-at-eof 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link
Collaborator

@rchlv rchlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Jen. This looks good to me, I'm happy to merge.

@rchlv rchlv merged commit c684b81 into mar-23-update Feb 16, 2024
11 of 12 checks passed
@rchlv rchlv deleted the review_check_qtr_format branch February 16, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants