Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to create_indiv_file #877

Merged

Conversation

SwiftySalmon
Copy link
Collaborator

Accidentally pushed to december branch because I am a silly goose so it'll probably not show the changes here

  • removed select from join_client in the episode file
  • removed part of function that filled in missing sc end dates as this is now dealt with elsewhere

marjom02 and others added 2 commits December 7, 2023 12:50
removed part of function that filled in missing sc end dates as this is now dealt with elsewhere
Copy link

github-actions bot commented Dec 7, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

beddays
GLS

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the remove_sc_missing_end_dates_from_indivfile branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7128447240/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 13
ℹ️ no-newline-at-eof 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@rchlv rchlv requested review from rchlv and Jennit07 December 7, 2023 12:58
@SwiftySalmon SwiftySalmon reopened this Dec 7, 2023
@SwiftySalmon SwiftySalmon merged commit 01f0d1b into dec-update-23 Dec 7, 2023
7 of 11 checks passed
@SwiftySalmon SwiftySalmon deleted the remove_sc_missing_end_dates_from_indivfile branch December 7, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants