Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bugs in the keep population flag. #874

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

SwiftySalmon
Copy link
Collaborator

  • filter out where gender not 1 or 2
  • deal with negative ages where dob is after mid point of year
  • previously filtered cases where dod was before midpoint, but was also accidentally removing cases with missing death dates! Now fixed.
  • added filter for nsu only once calculations are done

- filter out where gender not 1 or 2
- deal with negative ages where dob is after mid point of year
- previously filtered cases where dod was before midpoint, but was also accidentally removing cases with missing death dates! Now fixed.
- added filter for nsu only once calculations are done

This comment has been minimized.

This comment has been minimized.

lizihao-anu
lizihao-anu previously approved these changes Dec 5, 2023
Copy link
Contributor

@lizihao-anu lizihao-anu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Dec 5, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

popluation

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the bug_keep_population_flag branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7102393942/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 13
ℹ️ no-newline-at-eof 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Jennit07
Copy link
Collaborator

Jennit07 commented Dec 7, 2023

Just thought of another way to check this - I'll use the function to match onto the existing files and produce an extract for Laura. Then ill run the dementia code and see what output we get.

@SwiftySalmon SwiftySalmon merged commit bbf6447 into dec-update-23 Dec 7, 2023
1 check passed
@SwiftySalmon SwiftySalmon deleted the bug_keep_population_flag branch December 7, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants