Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/it extract path #807

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Tests/it extract path #807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cad5cf
Add additional tests for `check_it_reference()`
Moohan Aug 14, 2023
6cce742
Make the check on the IT reference stricter
Moohan Aug 14, 2023
4014254
Update documentation
Jennit07 Sep 25, 2023
0d90cf5
Merge branch 'development' into tests/it_extract_path
Jennit07 Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/get_it_extract_paths.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
if (is.null(it_reference)) {
it_ltc_path <- get_file_path(
directory = fs::path(get_slf_dir(), "IT_extracts"),
file_name_regexp = "SCTASK[0-9]{7}_LTCs\\.csv(?:\\.gz)?",

Check failure on line 17 in R/get_it_extract_paths.R

View workflow job for this annotation

GitHub Actions / Check Spelling 

`SCTASK` is not a recognized word. (unrecognized-spelling)
...
)
} else {
Expand All @@ -22,7 +22,7 @@

it_ltc_path <- get_file_path(
directory = fs::path(get_slf_dir(), "IT_extracts"),
file_name = stringr::str_glue("SCTASK{it_reference}_LTCs.csv.gz")

Check failure on line 25 in R/get_it_extract_paths.R

View workflow job for this annotation

GitHub Actions / Check Spelling 

`SCTASK` is not a recognized word. (unrecognized-spelling)
)
}

Expand All @@ -45,7 +45,7 @@
if (is.null(it_reference)) {
it_deaths_path <- get_file_path(
directory = fs::path(get_slf_dir(), "IT_extracts"),
file_name_regexp = "SCTASK[0-9]{7}_Deaths\\.csv(?:\\.gz)?",

Check failure on line 48 in R/get_it_extract_paths.R

View workflow job for this annotation

GitHub Actions / Check Spelling 

`SCTASK` is not a recognized word. (unrecognized-spelling)
...
)
} else {
Expand All @@ -53,7 +53,7 @@

it_deaths_path <- get_file_path(
directory = fs::path(get_slf_dir(), "IT_extracts"),
file_name = stringr::str_glue("SCTASK{it_reference}_Deaths.csv.gz")

Check failure on line 56 in R/get_it_extract_paths.R

View workflow job for this annotation

GitHub Actions / Check Spelling 

`SCTASK` is not a recognized word. (unrecognized-spelling)
)
}

Expand All @@ -78,7 +78,7 @@
it_pis_path <- get_file_path(
directory = fs::path(get_slf_dir(), "IT_extracts"),
file_name_regexp = stringr::str_glue(
"SCTASK[0-9]{{7}}_PIS_{convert_fyyear_to_year(year)}.csv(?:\\.gz)?"

Check failure on line 81 in R/get_it_extract_paths.R

View workflow job for this annotation

GitHub Actions / Check Spelling 

`SCTASK` is not a recognized word. (unrecognized-spelling)
)
)
} else {
Expand Down Expand Up @@ -107,7 +107,7 @@
it_reference <- stringr::str_sub(it_reference, start = 7L, end = 14L)
}

if (stringr::str_detect(it_reference, "[0-9]{7}", negate = TRUE)) {
if (stringr::str_detect(it_reference, "^[0-9]{7}$", negate = TRUE)) {
cli::cli_abort(
c("x" = "{.arg it_reference} must be exactly 7 numbers."),
call = rlang::caller_env()
Expand Down
22 changes: 22 additions & 0 deletions tests/testthat/test-get_it_extract_paths.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
test_that("IT reference cleanup works", {
expect_equal(check_it_reference("SCTASK0439133"), "0439133")
expect_equal(check_it_reference("0439133"), "0439133")

expect_error(
check_it_reference("123456789"),
"`it_reference` must be exactly 7 numbers\\."
)
expect_error(
check_it_reference("1234567890"),
"`it_reference` must be exactly 7 numbers\\."
)
expect_error(
check_it_reference("SCTASK123456789"),
"`it_reference` must be exactly 7 numbers\\."
)
expect_error(
check_it_reference("ABCDEF123456789"),
"`it_reference` must be exactly 7 numbers\\."
)
})

skip_on_ci()

test_that("IT extract file paths work", {
Expand Down
Loading