Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for anon_chi missing #752

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Fix for anon_chi missing #752

merged 4 commits into from
Jul 19, 2023

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Jul 19, 2023

slfhelper::get_anon_chi converts NA to "TkE=" which would then be converted back to "e1" 🤯

This fixes that by making NA CHIs blank "", then making blank anon_chis NA after.

slfhelper should be updated so that it always converts NA to NA.

`slfhelper::get_anon_chi` converts `NA` to "TkE=" which would then be converted back to "e1" 🤯

This fixes that by making NA CHIs blank `""`, then making blank anon_chis NA after.

slfhelper should be updated so that it always converts NA to NA.
@Moohan Moohan requested a review from Jennit07 July 19, 2023 09:41
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jul 19, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (2)

hhg
sparra

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the anon_chi_na branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5597598077/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link
Collaborator

@Jennit07 Jennit07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ready to merge

@Jennit07 Jennit07 added this pull request to the merge queue Jul 19, 2023
Merged via the queue into master with commit 74109bf Jul 19, 2023
@Jennit07 Jennit07 deleted the anon_chi_na branch July 19, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants