Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to SC client #707

Closed
wants to merge 9 commits into from
Closed

Updates to SC client #707

wants to merge 9 commits into from

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Jun 27, 2023

So far some minor updates to ensure all the client flags are kept from the data mart. However, I would like to change how the client file is used from the current: Matching it on to the Social Care data sets, to using it like the LTC, deaths, HHG etc lookups and matching it on for all CHIs in the episode and individual files. This second part hasn't been implemented yet, I'm not sure whether to merge these changes and do the second at some point later or to leave this and do everything in one go!

@github-actions

This comment has been minimized.

@Moohan Moohan changed the base branch from main-R to master July 3, 2023 10:40
@github-actions

This comment has been minimized.

@Moohan

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (1)

dvprod

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the sc_client branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5729552225/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This Pull Request is stale because it has been at least 30 days with no activity. It will be closed if there is no activity within 7 days.

@github-actions github-actions bot added the Stale label Sep 4, 2023
@github-actions
Copy link

This Pull Request was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Sep 11, 2023
@Jennit07 Jennit07 deleted the sc_client branch March 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant