Remove the anon_chi functions #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moohan
requested review from
a team,
lizihao-anu and
shintoLamp
and removed request for
a team
These are no longer needed as they are implemented in `{slfhelper}` and we can just import from there instead of maintaining two versions.
I checked and as far as I can tell there are no uses of these functions in the code that needed to be removed/changed.
Moohan
force-pushed
the
remove/anon_chi_functions
branch
from
7eb92d0
to
1b52288
Compare
Jennit07
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are no longer needed as they are implemented in
{slfhelper}and we can just import from there instead of maintaining two versions.I checked and as far as I can tell there are no uses of these functions in the code that needed to be removed/changed.