333 c02 link delayed discharges episodes

[lizihao-anu]

Linked to issue #333. The skeleton is ready for review. There are some small issues left that need help, such as the columns kept for delayed discharged files. See the comments for more information.

[Moohan]

Looking good. Some comments around how delays are being classified.

I think the main issue is that your join won't catch cases when

1. CIJ has a missing end date (i.e. ongoing MH record).
2. Delay record has a missing (i.e. ongoing delay).
3. Sometimes won't match when the delay has an amended end date. e.g. When the CIJ ends during the month but the delay has an end date of the end of the month.

[Jennit07]

This looks good to me. I ran the code with the existing run_episode_file and it works well. I will approve and await @Moohan feedback before merging! Thanks

[Moohan]

Quick pass correcting some lint issues

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (3)

hhg
nrs
sparra

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the 333-c02-link-delayed-discharges-episodes branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5155205432/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words not in the 📘 dictionary

This includes both expected items (206) from .github/actions/spelling/expect.txt and unrecognized words (3)

Dictionary	Entries	Covers
cspell:swift/src/swift.txt	205	2
cspell:cpp/src/cpp.txt	30216	2
cspell:sql/src/tsql.txt	455	1
cspell:python/src/python/python.txt	453	1
cspell:python/src/python/python-lib.txt	3873	1
cspell:python/src/common/extra.txt	741	1
cspell:npm/npm.txt	288	1
cspell:latex/latex.txt	424	1
cspell:java/java.txt	7642	1
cspell:html/html.txt	1863	1

Consider adding them using (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:swift/src/swift.txt
          cspell:cpp/src/cpp.txt
          cspell:sql/src/tsql.txt
          cspell:python/src/python/python.txt
          cspell:python/src/python/python-lib.txt
          cspell:python/src/common/extra.txt
          cspell:npm/npm.txt
          cspell:latex/latex.txt
          cspell:java/java.txt
          cspell:html/html.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[Moohan]

I'm happy with this, I suspect we'll find some issues in later testing but good to go now!

@Jennit07 I'm, approving but have made a few changes just now so I'll leave to you to re-review, approve and merge!

[Jennit07]

I'm happy with this, I suspect we'll find some issues in later testing but good to go now!

@Jennit07 I'm, approving but have made a few changes just now so I'll leave to you to re-review, approve and merge!

Had a look through the new commits and everything looks good. Will approve/merge!