-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review check_quarter_format
function
#886
Comments
requires investigation - decide if we actually need this as in our update we just excluded this for running. This mainly affected the individual file |
The function I have found that most quarter calculation functions are not needed. I have removed this and used There is one line being used in |
Opening a draft PR for now. I think we need to review the care home methodology before deciding if we need the quarter calculation functions. I will highlight areas in the code which i am not sure about as i want to make sure we pick up the correct logic. For now i have concluded that we can remove the `check_qtr_format` function so have removed this from the code. Closes Issue #886
This caused us issues when trying to run the individual file in the december update. Making a note to go back and review this - i have commented out the function for running purposes. See the script
get_fy_quarter_dates.R
https://github.com/Public-Health-Scotland/source-linkage-files/blob/dec-update-23/R/get_fy_quarter_dates.R
The text was updated successfully, but these errors were encountered: